Update SurgeXT.

[rl2939]

No description provided.

[dromer]

They didn't do a release yet, so maybe we should wait for that.

[fotisandstuff]

Ding, ding! https://github.com/surge-synthesizer/surge-rack/releases/tag/v2.2.6.0

[dromer]

Why are you closing PRs like this? It is unnecessary.
Leave them open so that someone can look at them.

[rl2939]

mod-plugin-builder is reporting errors:

Compiling RemoteWindow.cpp
In file included from /home/runner/work/Cardinal/Cardinal/dpf/dgl/src/nanovg/nanovg.c:66:0,
                 from RemoteNanoVG.cpp:40:
/home/runner/work/Cardinal/Cardinal/dpf/dgl/src/nanovg/stb_image.h: In function 'int stbi__tga_get_comp(int, int, int*)':
/home/runner/work/Cardinal/Cardinal/dpf/dgl/src/nanovg/stb_image.h:4856:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
       case 16: if(is_grey) return STBI_grey_alpha;
                ^~
/home/runner/work/Cardinal/Cardinal/dpf/dgl/src/nanovg/stb_image.h:4858:7: note: here
       case 15: if(is_rgb16) *is_rgb16 = 1;
       ^~~~
Compiling DistrhoPluginMain.cpp (LV2)
(cd ../../docs/ && pandoc MODDEVICES.md -f markdown+implicit_figures -o /home/runner/work/Cardinal/Cardinal/bin/Cardinal.lv2/modgui/documentation.pdf)
Creating LV2 plugin for Cardinal
/home/runner/work/Cardinal/Cardinal/deps/surge-build/libs/sst/sst-plugininfra/libsst-plugininfra.a(paths_linux.cpp.o): In function `sst::plugininfra::paths::sharedLibraryBinaryPath()':
paths_linux.cpp:(.text._ZN3sst11plugininfra5paths23sharedLibraryBinaryPathEv+0x18): undefined reference to `dladdr'
collect2: error: ld returned 1 exit status
make[3]: *** [../../dpf/Makefile.plugins.mk:665: ../../bin/Cardinal.lv2/Cardinal.so] Error 1

There is also an error in simd, but I am not sure what the error message is referring to.

[falkTX]

the MOD builds mean somewhere there is a missing -ldl linker argument.

[rl2939]

the MOD builds mean somewhere there is a missing -ldl linker argument.

I think I need some help here. The files that I think I can put the linker argument are either listed in the .gitignore or are supposed to be generated by CMake on compile time. (Or they don't fix the issue.)

[falkTX]

the MOD builds mean somewhere there is a missing -ldl linker argument.

I think I need some help here. The files that I think I can put the linker argument are either listed in the .gitignore or are supposed to be generated by CMake on compile time. (Or they don't fix the issue.)

Only the final linking is failing, not the building of surge libs, so we dont need to modify any temporary files.

https://github.com/DISTRHO/Cardinal/blob/main/src/Makefile.cardinal.mk#L193 likely the place to add -ldl but needs a check for not-windows-not-haiku-not-wasm-not-macos
DPF already have something for this, so I suspect this might do the trick:

ifneq ($(HAIKU_OR_MACOS_OR_WASM_OR_WINDOWS),true)
EXTRA_DSP_LIBS += -ldl
endif

that won't solve the wasm build though, that one fails in

 In file included from /home/runner/work/Cardinal/Cardinal/plugins/surgext/surge/libs/sst/sst-plugininfra/src/cpufeatures.cpp:42:
/home/runner/PawPawBuilds/emsdk/upstream/lib/clang/16/include/cpuid.h:14:2: error: this header is for x86 only
#error this header is for x86 only

so it's required to patch surge source code

[rl2939]

DPF already have something for this, so I suspect this might do the trick:

ifneq ($(HAIKU_OR_MACOS_OR_WASM_OR_WINDOWS),true)
EXTRA_DSP_LIBS += -ldl
endif

That worked, thanks for the help! All build checks have passed.

[falkTX]

nice. I want to release 26.01 this week though, and this is too risky to add as last minute.
so to merge after the release