Fix Page Up/Down keys#165
Open
mjbnz wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Appears that PgDn is still buggy after this patch, but it's still better than the always "go to last item" that it did before. |
Signed-off-by: Mike Beattie <mike@ethernal.org>
Previously, if nothing was selected, the last item on the drawlist would always be selected because the check of scrpos would never match. It should have been "< bottomDrawLine - 1". Now it should correctly select the last item on the screen. Signed-off-by: Mike Beattie <mike@ethernal.org>
Contributor
Author
|
Spent some time fixing this properly, it's now fairly reliable and behaviour matches list UIs in other console apps. |
Signed-off-by: Mike Beattie <mike@ethernal.org>
Contributor
Author
|
Hello, any chance that this PR might be accepted? |
Member
Sorry I was busy and lost track of your PR.I'm going to take a look at it so it could be part of the next bugfixing release apt-dater 1.0.4 (so it get's into Debian Bulldozer). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very simple fix -
reorderScrpos()was being called withbottomDrawLine, but that's not the last drawndrawlistitem.