Added ability to propose a Hornbostel-Sachs number#511
Draft
PouyaMohseni wants to merge 12 commits intodevelopfrom
Draft
Added ability to propose a Hornbostel-Sachs number#511PouyaMohseni wants to merge 12 commits intodevelopfrom
PouyaMohseni wants to merge 12 commits intodevelopfrom
Conversation
Member
|
This overlaps with the new instrument feature. I recommend you to hold this now. |
PouyaMohseni
force-pushed
the
add-hbs
branch
2 times, most recently
from
6aed348 to
770dab5
Compare
- Added HornbostelSachs model with fields: instrument FK, hornbostel_sachs_class, contributor, is_main, review_status, on_wikidata - Linked HornbostelSachs to Instrument model via FK - Auto-update instrument main HBS and unset others on save
- Handle add-class modal and form - Update NameValidator to validate HBS input - Posts classification through instrument/<int:pk>/names/ endpoint
- show main Hornbostel-Sachs class on instrument detail page - add buttons to propose or edit HBS if authenticated - include addClass.html partial
- Enable list filtering by `review_status` - Restrict editable fields for users in the 'reviewer' group
- proposals are linked to the input to make them easier to be edit
PouyaMohseni
force-pushed
the
add-hbs
branch
from
770dab5 to
9fed4e7
Compare
Member
|
Please make sure all the checks pass before marking ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update modifies the current instrument model because HBS entries now require reviewer validation. The implementation allows:
resolves #496
Examples:
UI for proposing an HBS:
Basic validation function:
Show proposals of other users:
Contributor view when the proposal is under review:
