feat: link to the Attack Mode Approvals dashboard#32
Open
Equious wants to merge 1 commit into
Open
Conversation
- Add an "Approvals" link to the header tools nav (next to Bridge), pointing at the approvals dashboard with ?chain=<l2ChainId> to pre-select the network. - Every Safe Harbor agreement view (agreements list, contract page, promotion flow — all render AgreementDetails) now shows a "View status on Approvals" deep link to that agreement's state: <dashboard>/request/<agreement>?chain=<id>. - New NetworkConfig.approvalsUrl override + APPROVALS_URL default (https://approvals.battlechain.com); i18n labels added. The dashboard is a single app serving both networks, so links carry ?chain= to open on the correct one (requires the dashboard to honor the param). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
API E2E Test Results220 tests 220 ✅ 17s ⏱️ Results for commit 7544803. |
API Prividium E2E Test Results4 tests 4 ✅ 6s ⏱️ Results for commit 7544803. |
Unit Test Results 4 files 273 suites 11m 31s ⏱️ Results for commit 7544803. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaces the Approvals dashboard from the explorer in two places. Verified locally against the prod mainnet API (nav link + per-agreement deep links resolve correctly).
1. Nav link (next to Bridge)
Adds an "Approvals" entry to the header tools nav. Built from
currentNetwork.approvalsUrl ?? APPROVALS_URL, with?chain=<l2ChainId>so it opens the dashboard on the network you're viewing.2. Per-agreement deep link
Every Safe Harbor agreement view now shows a "View status on Approvals" link next to the agreement address, deep-linking to that agreement's state:
<dashboard>/request/<agreementAddress>?chain=<l2ChainId>.This lives in
AgreementDetails.vue, which renders in all agreement contexts — the agreements list, the contract/address page, and the go-to-production flow — so it's covered everywhere with one change.Supporting bits
NetworkConfig.approvalsUrl?(optional per-network override) +APPROVALS_URLdefault inconfigs/index.tsheader.nav.approvals,safeHarbor.viewOnApprovalsCross-repo dependency (already shipped)
The dashboard is a single app serving both networks, so these links pass
?chain=. The companion bc-approvals change to honor?chain=626|627on load is already merged and deployed to approvals.battlechain.com.🤖 Generated with Claude Code