feat: ownership on view dossier and action#347
Draft
alexandre-gauvin wants to merge 67 commits into
Draft
Conversation
Related Issue: multi_owner-view-dossier-actions
…anging it Related Issue: multi_owner-view-dossier-actions
Related Issue: multi_owner-view-dossier-actions
Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
…sier) Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
…ions) Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
…ming Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Contributor
Error Output |
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
cccs-mdr
requested changes
May 19, 2026
cccs-mdr
left a comment
Collaborator
There was a problem hiding this comment.
Assuming the UI side will come in a separate PR?
|
|
||
| from opentelemetry import trace | ||
| from passlib.hash import bcrypt | ||
| from passlib.handlers.bcrypt import bcrypt |
Collaborator
There was a problem hiding this comment.
This should not be changed - I've resolve this in another branch, merging develop should resolve the original error.
| from authlib.integrations.base_client import OAuthError | ||
| from flask import current_app, request | ||
| from passlib.hash import bcrypt | ||
| from passlib.handlers.bcrypt import bcrypt |
Collaborator
There was a problem hiding this comment.
Same deal - merge develop and this change should not be necessary
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
…owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Related Issue: multi_owner-view-dossier-actions
Copilot
AI
changed the title
feat: support membership and multiple ownership for views, dossiers, and actions
Store view owner as a string
Jun 10, 2026
…dossier.d Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
…object as well Signed-off-by: agauvin <alexandre.gauvin@cse-cst.gc.ca> Related Issue: multi_owner-view-dossier-actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View ownership was modeled and handled as a list even though each view should have exactly one owner. This made ownership semantics inconsistent across the API, persistence model, and tests.
Model
View.ownerfromlist[str]tostr.owner, but now it resolves to a single username.API behavior
PUT /view/{id}/permissiontreatsowneras a transfer target, not a multi-value membership set.DELETEonowneris rejected to preserve single-owner semantics.Test/data updates