fix envector lint #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses linting issues in the envector client codebase by reorganizing imports, removing unused imports, and applying modern Python typing conventions.
Key changes:
- Standardized import ordering to follow Python conventions (stdlib imports before third-party)
- Modernized type hints by replacing
DictwithdictandIterabletyping - Removed unused imports and unnecessary else clauses
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vectordb_bench/log_util.py | Reordered imports to place os after standard library imports |
| vectordb_bench/backend/clients/envector/envector.py | Reorganized imports, modernized type hints from Dict to dict, and removed unnecessary else clause |
| vectordb_bench/backend/clients/envector/config.py | Removed unused SQType import |
| vectordb_bench/backend/clients/envector/cli.py | Alphabetically sorted imports in two function locations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
inkme9
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix envector lint