Skip to content

Fix MapGenStructure saving data globally rather than per world#177

Merged
EverNife merged 1 commit intoCrucibleMC:stagingfrom
MellowArpeggiation:fix-mapgenstructure
Dec 4, 2025
Merged

Fix MapGenStructure saving data globally rather than per world#177
EverNife merged 1 commit intoCrucibleMC:stagingfrom
MellowArpeggiation:fix-mapgenstructure

Conversation

@MellowArpeggiation
Copy link
Copy Markdown
Contributor

In NTM: Space, NBT structure generation (backported from modern jigsaw structure gen) would spawn structures in all dimensions due to the world save data NBT being stored in global storage rather than per world storage, which is a regression from the Forge patch which changes that behaviour. This PR restores the expected Forge patch behaviour.

…ng structures from certain mods to spawn in the wrong dimensions
@FadeTNT1
Copy link
Copy Markdown

Thanks Mellow!!

@EverNife
Copy link
Copy Markdown
Member

This seems correct as well, default forge behavior is perWorldStorage.

image

Gonna test this feature on my modpack, i have a few bugs related to Thaumcraft building, see if has anythig related.

@EverNife EverNife self-requested a review May 26, 2025 22:28
@MellowArpeggiation
Copy link
Copy Markdown
Contributor Author

My compat code in NTM: Space to fix this issue is causing crashes with other mods, due to using an access transformer on a private method in order to override it (which does not like being mixin'ed). This being merged and put into a release would solve me a lot of headaches! Is this project still maintained?

@gravit0
Copy link
Copy Markdown
Contributor

gravit0 commented Sep 24, 2025

PR merged into my branch RetroForge#3

@EverNife
Copy link
Copy Markdown
Member

My compat code in NTM: Space to fix this issue is causing crashes with other mods, due to using an access transformer on a private method in order to override it (which does not like being mixin'ed). This being merged and put into a release would solve me a lot of headaches! Is this project still maintained?

Try with gravit0 fork RetroForge#3

If it works there, i will be merging this pr

@MellowArpeggiation
Copy link
Copy Markdown
Contributor Author

My compat code in NTM: Space to fix this issue is causing crashes with other mods, due to using an access transformer on a private method in order to override it (which does not like being mixin'ed). This being merged and put into a release would solve me a lot of headaches! Is this project still maintained?

Try with gravit0 fork RetroForge#3

If it works there, i will be merging this pr

Gave it a go, works as expected!

@EverNife EverNife merged commit 62f240b into CrucibleMC:staging Dec 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants