Make Basins render their fluid correctly on contraptions #9168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vercte
added
area: rendering
TropheusJ
requested changes
Oct 23, 2025
src/main/java/com/simibubi/create/content/processing/basin/BasinMovementBehaviour.java
Show resolved
Hide resolved
| if (basin != null) { | ||
| basin.read(context.blockEntityData, true); | ||
| basin.tick(); | ||
| BlockEntityRenderHelper.renderBlockEntities(context.world, renderWorld, List.of(basin), |
There was a problem hiding this comment.
a new renderInContraption method should be used instead, like other actors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes basins tick on the client in order to both update their behaviors and properly display the level of fluid inside them.