Replace / as division operation with the new math.div function in sass issue #102#104
Open
tarekelkanaria wants to merge 1 commit intoConnorAtherton:masterfrom
Open
Conversation
|
any published repo in npm ? |
Author
do you mean I need to publish a repo in npm to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace / as division operation with the new math.div function in sass issue #102
reference from Sass: https://sass-lang.com/documentation/breaking-changes/slash-div
in src/animations/pacman.scss file lines 46 and 88 I use the new math.div function in sass to remove deprecation warning about the old slash operation for division
in src/animations/ball-scale-multiple.scss file line 33 I use the same math.div to resolve issue #102