- Added support for custom data in the MediaInfo object class + other fix #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoMino
commented
Dec 23, 2015
GoMino
commented
- Make sure the ConnectableDevice id is set with the serviceDescription UUID if any, instead of a generated one.
- Fix the ConnectableDevice constructor with a JSONObject as argument to properly initialize the serialized DeviceServices if any.
- Fix a bug where the serviceDescription does not get set to the ConnectableDevice when first discovered (was only set on the DeviceService at first, and then on the ConnectableDevice, when it get updated).
- Added Support for startPosition and customData parameters in playMedia method of MediaPlayer capability.
- Make sure the ConnectableDevice id is set with the serviceDescription UUID if any, instead of a generated one. - Fix the ConnectableDevice constructor with a JSONObject as argument to properly initialize the serialized DeviceServices if any. - Fix a bug where the serviceDescription does not get set to the ConnectableDevice when first discovered (was only set on the DeviceService at first, and then on the ConnectableDevice, when it get updated). - Added Support for startPosition and customData parameters in playMedia method of MediaPlayer capability.
This was referenced Dec 23, 2015
There was a problem hiding this comment.
You should probably use 'optJSONObject here, just like the piece of code above this.
There was a problem hiding this comment.
You are right, I added a new commit to fix that, thanks!
…ice + Fix SSDPDeviceTest case for new support library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.