Maintain a single static instance of DiscoveryManager. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the situation that there are 2 SDKs (SDK_A and SDK_B) using ConnectSDK. Both of them run
DiscoveryManager.init()in theirSDK.init()method and told their clients to run it inApplication.onCreate(). 2DiscoveryManagerinstances will be created in that case, and potentially leaked aDiscoveryManager.This pull request will make sure there is only one single static instance of
DiscoveryManagerwill be used. EventDiscoveryManager.init()is run twice, only oneDiscoveryManagerwill be used.Also, making
DiscoveryManager's constructor private can prevent clients from creating multiple instances ofDiscoveryManager, as it is not recommended already in the original code.