Change validation method for Lenovo BIOS passwords#15
Open
pasqualm wants to merge 3 commits intoConfigJon:masterfrom
Open
Change validation method for Lenovo BIOS passwords#15pasqualm wants to merge 3 commits intoConfigJon:masterfrom
pasqualm wants to merge 3 commits intoConfigJon:masterfrom
Conversation
The operation SetBiosPassword needs a reboot to be efective. After the first execution, all SetBiosPassword operations will fail even if the password is correct until the reboot. This can create a problem if you do multiple Manage-LenovoBiosSettings operations without rebooting between them. The method for checking if the password is correct is changed to trying to set a value with it's current value to try to avoid this situation
Author
|
Hi Jon Best regards :) |
Some HP models return the config info with a space in front of them. Change to manage correctly this situation
Some HP models return the config info with a space in front of them. Change to manage correctly this situation when setting values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operation SetBiosPassword needs a reboot to be efective. After the first execution, all SetBiosPassword operations will fail even if the password is correct until the reboot.
This can create a problem if you do multiple Manage-LenovoBiosSettings operations without rebooting between them.
The method for checking if the password is correct is changed to trying to set a value with it's current value to try to avoid this situation