-
Notifications
You must be signed in to change notification settings - Fork 1
static libc link in examples #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
On the cluster: |
lchladek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix compile
|
@lchladek can you confirm that it works now? (you can get the release from the artefacts) curl -L \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer <your-pat-token>" \
-H "X-GitHub-Api-Version: 2022-11-28" \
https://api.github.com/repos/ConSol-Lab/gourd/actions/artifacts/3166061639 \
--output ./install_delftblue.zip
unzip ./install_delftblue.zip
|
|
also I can confirm that the current release on main does not work on delftblue, so I am confident this was the fix:) |
|
Verified that this works on macOS. I am approving, please merge. |
lchladek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back, minor changes are needed. Good that you fixed the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be in the commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see you've removed it from gitignore, but isn't the static linking only supposed to be relevant for examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc we link all linux binaries against musl. I am not sure why this wasn't here or why it worked without
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall facing the issue when Emir (and some others) first tried testing it on delftblue that gourd didn't work at all because of glibc diff between GitHub runners and delftblue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but seems fishy. @mgazeel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to clarify, I had .cargo/config.toml locally (on delftblue) already so any version of gourd I compiled and tested on the cluster had this config
can you also confirm it works on delftblue? it has always worked on macOS:) you can get the binaries from the next pipeline, (through curl only with a gh personal access token) |
|
You've shown that in the screenshot, is there anything else I should test? |
reproducing the results would be nice |


closes #49