Skip to content

Conversation

@andtsa
Copy link
Member

@andtsa andtsa commented May 13, 2025

closes #49

@andtsa andtsa requested a review from lchladek May 13, 2025 20:11
@lchladek
Copy link
Contributor

On the cluster:

[lchladek@login02 gourd]$ cargo build --release
   Compiling libz-sys v1.1.22
   Compiling openssl-sys v0.9.108
   Compiling ring v0.17.14
   Compiling gourd v1.2.1 (/home/lchladek/gourd)
   Compiling libssh2-sys v0.3.1
   Compiling libgit2-sys v0.16.2+1.7.2
   Compiling rustls v0.23.27
   Compiling rustls-webpki v0.103.3
   Compiling ureq v2.12.1
   Compiling git2 v0.18.3
error: linking with `cc` failed: exit status: 1
  |
  = note:  "cc" "-m64" "/tmp/rustcWiLNEf/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/tmp/rustcWiLNEf/{libring-a06908e79b228bd3.rlib,liblibgit2_sys-d47faa31a60e7a47.rlib,liblibssh2_sys-e924895060066b1c.rlib}.rlib" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lssl" "-lcrypto" "-lz" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/home/lchladek/gourd/target/release/build/libgit2-sys-5fa7a496d615575a/out/build" "-L" "/home/lchladek/gourd/target/release/build/libssh2-sys-456cd4ba05dd4abe/out/build" "-L" "/apps/arch/2024r1/software/linux-rhel8-cascadelake/gcc-11.3.0/zlib-1.2.13-dfvbbqwz3ttn73k47j4sbrjwzvnhde5r/lib" "-L" "/home/lchladek/gourd/target/release/build/ring-15f858b44c77150b/out" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/home/lchladek/gourd/target/release/deps/gourd-b8da971dd6c16167" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-all" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /usr/bin/ld: /tmp/rustcWiLNEf/libring-a06908e79b228bd3.rlib(25ac62e5b3c53843-curve25519.o): unable to initialize decompress status for section .debug_info
          /usr/bin/ld: /tmp/rustcWiLNEf/libring-a06908e79b228bd3.rlib(25ac62e5b3c53843-curve25519.o): unable to initialize decompress status for section .debug_info
          /usr/bin/ld: /tmp/rustcWiLNEf/libring-a06908e79b228bd3.rlib(25ac62e5b3c53843-curve25519.o): unable to initialize decompress status for section .debug_info
          /usr/bin/ld: /tmp/rustcWiLNEf/libring-a06908e79b228bd3.rlib(25ac62e5b3c53843-curve25519.o): unable to initialize decompress status for section .debug_info
          /tmp/rustcWiLNEf/libring-a06908e79b228bd3.rlib: error adding symbols: File format not recognized
          collect2: error: ld returned 1 exit status


error: could not compile `gourd` (bin "gourd") due to 1 previous error
[lchladek@login02 gourd]$

Copy link
Contributor

@lchladek lchladek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix compile

@andtsa andtsa requested a review from lchladek May 13, 2025 20:49
@andtsa andtsa added draft run draft pipeline (this PR is not ready to merge) release run release pipeline (generate installers) labels May 21, 2025
@andtsa
Copy link
Member Author

andtsa commented May 26, 2025

@lchladek can you confirm that it works now?

(you can get the release from the artefacts)

curl -L \
  -H "Accept: application/vnd.github+json" \
  -H "Authorization: Bearer <your-pat-token>" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  https://api.github.com/repos/ConSol-Lab/gourd/actions/artifacts/3166061639 \
  --output ./install_delftblue.zip
unzip ./install_delftblue.zip
image

@andtsa
Copy link
Member Author

andtsa commented May 26, 2025

also I can confirm that the current release on main does not work on delftblue, so I am confident this was the fix:)

@lchladek
Copy link
Contributor

lchladek commented Jun 9, 2025

Verified that this works on macOS. I am approving, please merge.

Copy link
Contributor

@lchladek lchladek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it back, minor changes are needed. Good that you fixed the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be in the commit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you've removed it from gitignore, but isn't the static linking only supposed to be relevant for examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc we link all linux binaries against musl. I am not sure why this wasn't here or why it worked without

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall facing the issue when Emir (and some others) first tried testing it on delftblue that gourd didn't work at all because of glibc diff between GitHub runners and delftblue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but seems fishy. @mgazeel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clarify, I had .cargo/config.toml locally (on delftblue) already so any version of gourd I compiled and tested on the cluster had this config

@andtsa
Copy link
Member Author

andtsa commented Jun 9, 2025

Verified that this works on macOS. I am approving, please merge.

can you also confirm it works on delftblue? it has always worked on macOS:)

you can get the binaries from the next pipeline, (through curl only with a gh personal access token)

@lchladek
Copy link
Contributor

lchladek commented Jun 9, 2025

You've shown that in the screenshot, is there anything else I should test?

@andtsa
Copy link
Member Author

andtsa commented Jun 9, 2025

You've shown that in the screenshot, is there anything else I should test?

reproducing the results would be nice

@lchladek
Copy link
Contributor

lchladek commented Jun 9, 2025

Good catch. The error is actually exactly the same as before.
Screenshot 2025-06-09 at 4 30 12 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

draft run draft pipeline (this PR is not ready to merge) release run release pipeline (generate installers)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix examples on DelftBlue

3 participants