Add lockState support to vehicle properties #83
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I’d like to propose a small improvement to vehicle properties handling. This change adds support for the vehicle door lock state (lockState) by: - Including lockState in the VehicleProperties type - Reading the value using GetVehicleDoorLockStatus in getVehicleProperties - Applying the value using SetVehicleDoorsLocked in setVehicleProperties This allows vehicle lock status to be properly saved and restored alongside other vehicle properties. Let me know if this fits the project direction or if any adjustments are needed. This allows the vehicle lock status to be properly saved and restored alongside other vehicle properties. Note: Two additional commits and pull requests were accidentally opened during this process and have already been closed. Sorry for the noise. Thank you! Signed-off-by: Angelo Rodrigues De Morais Barroso <[email protected]>
There was a problem hiding this comment.
Pull request overview
This pull request adds support for saving and restoring vehicle door lock state alongside other vehicle properties. The lock state can now be captured when getting vehicle properties and restored when setting them.
Changes:
- Added
lockStatefield to theVehiclePropertiestype definition - Modified
getVehiclePropertiesto capture the current lock state usingGetVehicleDoorLockStatus - Modified
setVehiclePropertiesto restore the lock state usingSetVehicleDoorsLocked
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I’d like to propose a small improvement to vehicle properties handling.
This change adds support for the vehicle door lock state (lockState) by:
This allows vehicle lock status to be properly saved and restored alongside other vehicle properties.
Let me know if this fits the project direction or if any adjustments are needed. This allows the vehicle lock status to be properly saved and restored alongside other vehicle properties.
Note: Two additional commits and pull requests were accidentally opened during this process and have already been closed. Sorry for the noise.
Thank you!