Skip to content

Increase minimum pyav version. - #15827

Merged
comfyanonymous merged 1 commit into
masterfrom
comfyanonymous-patch-1
Aug 23, 2026
Merged

Increase minimum pyav version.#15827
comfyanonymous merged 1 commit into
masterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bf2bba45-125b-4ee2-b1cd-114f6d401c32

📥 Commits

Reviewing files that changed from the base of the PR and between 82f839f and a64b208.

📒 Files selected for processing (1)
  • requirements.txt

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (14)
  • GitHub Check: test (ubuntu-latest)
  • GitHub Check: test (windows-2022)
  • GitHub Check: test (ubuntu-latest)
  • GitHub Check: test (windows-latest)
  • GitHub Check: test (macos-latest)
  • GitHub Check: test (macos-latest)
  • GitHub Check: Run Pylint
  • GitHub Check: test
  • GitHub Check: Build Test (3.10)
  • GitHub Check: Build Test (3.11)
  • GitHub Check: Build Test (3.12)
  • GitHub Check: Build Test (3.13)
  • GitHub Check: Build Test (3.14)
  • GitHub Check: Run Pylint
🧰 Additional context used
📓 Path-based instructions (3)
**/*

📄 CodeRabbit inference engine (AGENTS.md)

**/*: Keep changes small, direct, and limited to the narrowest necessary code path and smallest number of files.
Prefer practical fixes, minimal dependencies, and existing repository patterns; remove obsolete, dead, unreachable, or unused code.
Preserve existing APIs, node names, model-loading behavior, file layout, and workflow compatibility unless replacement is explicitly intended.
Core ComfyUI must not add outbound internet requests, telemetry, tracking, reporting, remote configuration, or background network activity. User-authorized model downloads are limited to the requested artifact and must exclude telemetry and unrelated metadata.

Files:

  • requirements.txt
**/*.{py,md,txt,json}

📄 CodeRabbit inference engine (AGENTS.md)

Keep warning and info messages short and actionable, remove noisy or misleading logging, and make documentation edits concise, factual, and tied to changed behavior.

Files:

  • requirements.txt
**

⚙️ CodeRabbit configuration file

**: IMPORTANT: Only comment on issues directly introduced by this PR's code changes.
Treat AGENTS.md as mandatory repository policy, not optional style guidance.
Flag PR changes that violate AGENTS.md even when the code is otherwise functional.
In particular, enforce architecture boundaries, dtype/device/memory rules,
interface contracts, import style, no unnecessary try/except blocks, no inline
imports, no outbound internet paths in core ComfyUI, and narrow scoped fixes.
Prefer direct findings over suggestions when a rule is violated. Only ignore
AGENTS.md when it clearly conflicts with a newer explicit maintainer instruction
in the PR.
Do NOT flag pre-existing issues in code that was merely moved, re-indented,
de-indented, or reformatted without logic changes. If code appears in the diff
only due to whitespace or structural reformatting (e.g., removing a with: block),
treat it as unchanged. Contributors should not feel obligated to address
pre-existing issues outside the scope of their contribution.

Files:

  • requirements.txt
🧠 Learnings (1)
📚 Learning: 2026-02-24T06:20:53.084Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI PR: 12604
File: requirements.txt:0-0
Timestamp: 2026-02-24T06:20:53.084Z
Learning: When reviewing Python dependency files, do not flag or comment on whether a package version exists on PyPI. Treat versions in requirements.txt as valid and focus reviews on correctness of syntax, formatting, and usage rather than PyPI availability.

Applied to files:

  • requirements.txt
🔇 Additional comments (1)
requirements.txt (1)

24-24: 🩺 Stability & Availability

Verify the new minimum installation before merge.

The dependency change is appropriately narrow and does not add compatibility code. Install av==17.0.0 from a clean supported environment, then run the existing PyAV audio and video paths. This verifies compatibility with comfy_extras/nodes_video.py and tests-unit/comfy_api_nodes_test/audio_conversions_test.py.

As per path instructions, verify the updated minimum version installs successfully.

Source: Path instructions


📝 Walkthrough

Walkthrough

The pull request updates the minimum required av version in requirements.txt from 16.0.0 to 17.0.0. No public entities change.

Merge Risk: ⚪ Minimal · up to a64b2

The minimum PyAV version is increased in a narrow dependency-only change. No actionable merge-blocking risk remains beyond normal installation and media-path checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the change has no supporting context. Add a brief description that states the minimum av version changes from 16.0.0 to 17.0.0.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the change to increase the minimum PyAV version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@comfyanonymous
comfyanonymous merged commit b78cec8 into master Aug 23, 2026
22 checks passed
@comfyanonymous
comfyanonymous deleted the comfyanonymous-patch-1 branch August 23, 2026 16:29
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants