Change the FID field to ID#1
Open
ryanfranz wants to merge 13 commits into
Open
Conversation
Member
|
Thanks, I'll integrate it. Sorry, I haven't got to it yet, I'm in crunch
mode for a demo next week right now. I'll merge that into my Option1d code
as well.
…On Thu, Mar 21, 2019 at 3:09 PM ryanfranz ***@***.***> wrote:
Kevin,
I fixed option1.py to use the id field rather than the fid field. You are
welcome to merge my change in, if you want.
Thanks,
Ryan
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- Change the FID field to ID
File Changes
- *M* Converters/Option1.py
<https://github.com/Cognitics/GeoCDB/pull/1/files#diff-0> (2)
Patch Links:
- https://github.com/Cognitics/GeoCDB/pull/1.patch
- https://github.com/Cognitics/GeoCDB/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFXWNJWePx_f8jjUWYf_qeW1QTbAdLTYks5vY_UOgaJpZM4cCYLg>
.
|
Fix floating point numbers to convert correctly
Author
|
One more change to fix a crash when a shapefile doesn't have a class-level dbf attribute file (caused a crash on Yemen CDB Navigation data) |
…nd need a better conversion to be a boolean
Added converter procedure
| #convertSHP(sqliteCon,shpFilename,outputGeoPackageFile, fClassRecords, True) | ||
| sqliteCon = sqlite3.connect(outputGeoPackageFile) | ||
| if(createExtendedAttributesTable(sqliteCon,shpFilename)): | ||
| if(0 and createExtendedAttributesTable(sqliteCon,shpFilename)): |
There was a problem hiding this comment.
Ryan, could you please explain why you want to disable the above if statement ?
Author
There was a problem hiding this comment.
This code crashes on Yemen (Tiles\N12\E044\201_RoadNetwork\L00\U0\N12E044_D201_S002_T003_L00_U0_R0.shp). It is trying to get the CNAM attribute, but from an extended attribute DBF file where one doesn't exist. Since it wasn't converting correctly anyway, I disabled it.
Bug fixes for related tables
…input dir and output dir) Fixed the setting of class-level attributes, fixed boolean and float fields Various cleanups to make these files almost identical
…mn as integers to facilitate faster SQL queries
…o that an empyt class-level attribute file doesn't prevent attributes from being created
…e populated into the table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kevin,
I fixed option1.py to use the id field rather than the fid field. You are welcome to merge my change in, if you want.
Thanks,
Ryan