Skip to content

Conversation

@Ashjz
Copy link

@Ashjz Ashjz commented Sep 2, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Every request has been done like what has been asked

@netlify
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit bd1333c
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68c1fef9a4560c0008990697
😎 Deploy Preview https://deploy-preview-739--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@Ashjz Ashjz changed the title London | ITP-MAY-25 | Mohammad Jafarzadeh(MR_ASH) | Wireframe London | ITP-Sep-25 | Mohammad Jafarzadeh(MR_ASH) | Wireframe Sep 2, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@Ashjz Ashjz changed the title London | ITP-Sep-25 | Mohammad Jafarzadeh(MR_ASH) | Wireframe London | ITP-Sep-25 | Mohammad Jafarzadeh | Wireframe Sep 2, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@Ashjz Ashjz changed the title London | ITP-Sep-25 | Mohammad Jafarzadeh | Wireframe London | 25-ITP-Sep | Mohammad Jafarzadeh | Sprint 1 | Wireframe Sep 2, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

@Ashjz Ashjz linked an issue Sep 2, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

@Ashjz Ashjz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Sep 2, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 9, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this sprint task - I have left some comments for parts you need to work on.

Also, in the pull requests "Changelist" section, it is expected that you give a brief explanation of what major changes you made.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good answers for the questions - but they are in a different file, how would I see these if I was only looking at your webpage?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? This is the same web page that I previously used in my May cohort and passed everything on, and exactly everything was on the same page then. Some reviewers asked me to link to other pages. Why all of these useless feutures?

width: 100%;
object-fit: cover;
text-align: center;
padding: 15px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your webpage styling is very nice, but If I look at this page on a desktop, the page has unnecessary scrollbars for scrolling left and right. This is a common problem and can make a webpage seem poorly designed. Can you find out why this is happening?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2025
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

08 Wireframe to Web Code

2 participants