-
-
Notifications
You must be signed in to change notification settings - Fork 356
London | 25-ITP-Sep | Mohammad Jafarzadeh | Sprint 1 | Wireframe #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f7e0a26.
…png, and readme.png.webp
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this sprint task - I have left some comments for parts you need to work on.
Also, in the pull requests "Changelist" section, it is expected that you give a brief explanation of what major changes you made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good answers for the questions - but they are in a different file, how would I see these if I was only looking at your webpage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? This is the same web page that I previously used in my May cohort and passed everything on, and exactly everything was on the same page then. Some reviewers asked me to link to other pages. Why all of these useless feutures?
| width: 100%; | ||
| object-fit: cover; | ||
| text-align: center; | ||
| padding: 15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your webpage styling is very nice, but If I look at this page on a desktop, the page has unnecessary scrollbars for scrolling left and right. This is a common problem and can make a webpage seem poorly designed. Can you find out why this is happening?

Learners, PR Template
Self checklist
Changelist
Every request has been done like what has been asked