West Midlands | ITP-Sep-25 | Baba Yusuf | Sprint 1 | Module-data-groups/Sprint-1 #870
Conversation
…omprehensive tests
Baba05206
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Baba05206
added
📅 Sprint 1
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
bot
removed
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Baba05206
changed the title
Baba05206
added
the
Needs Review
tenzyns
added
Review in progress
| for (let index = 0; index < list.length; index++) { | ||
| const element = list[index]; | ||
| for (const element of list) { | ||
| if (element === target) { |
There was a problem hiding this comment.
does the test pass for this? This doesn't seem to return false in any case. And a test case is expecting a false.
|
Very well written. Just one comment on the refactor/include.js file. |
tenzyns
added
Reviewed
Baba05206
added
the
Needs Review
|
@tenzyns , may I ask for your feedback on the updated response please? Thank you. |
tenzyns
added
Complete
|
Looks good. ✔️ |
3 participants
Learners, PR Template
Self checklist
Changelist
This PR contains the completest tasks for Sprint-1. Tasks: Fix, Implement & Refactor have been completed.