Skip to content

GLASGOW | May-2025 | Taras Mykytiuk | Sprint 2 | Book library #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TarasMykytiuk wants to merge 8 commits into from
Closed

GLASGOW | May-2025 | Taras Mykytiuk | Sprint 2 | Book library #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
896cf58
first commit
TarasMykytiuk Aug 17, 2025
7b319e7
bugfixing
TarasMykytiuk Aug 17, 2025
1b78ee4
Merge branch 'CodeYourFuture:main' into book_library
TarasMykytiuk Aug 17, 2025
ff05f0f
index.html fixed
TarasMykytiuk Aug 18, 2025
af12243
Merge branch 'book_library' of https://github.com/TarasMykytiuk/Modul…
TarasMykytiuk Aug 18, 2025
6dcafb4
script.js fixed according to feedback.md
TarasMykytiuk Aug 18, 2025
bafe966
reaction to feedback
TarasMykytiuk Aug 19, 2025
5ed9f1c
reaction to feedback
TarasMykytiuk Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Library</title>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
>
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -31,42 +28,42 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
>
<label for="pages">Pages quantity:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
>
</div>
</div>

Expand All @@ -93,4 +90,4 @@ <h1>Library</h1>

<script src="script.js"></script>
</body>
</html>
</html>
93 changes: 50 additions & 43 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@ let myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
Expand All @@ -20,25 +19,42 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const bookTitleInput = document.getElementById("title");
const bookAuthorInput = document.getElementById("author");
const bookNumberOfPagesInput = document.getElementById("pages");
const isBookReadCheckBox = document.getElementById("check");

// To check if pages input can be safely converted to integer
function isValidInteger(input) {
return Number.isInteger(input);
}
// prevent accidental hexadecimal input
function isHexadecimal(input) {
return /^0x[0-9a-fA-F]+$/.test(input);
}
Comment on lines +32 to +34
Copy link
Contributor

@cjyuan cjyuan Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you want to allow the user to enter a page count as a hexadecimal number?

Copy link
Author

@TarasMykytiuk TarasMykytiuk Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont allow. When user try to input something like: "0x10" - this function return true and condition in line 50 trigger error alert window in line 53.


//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
const bookTitle = bookTitleInput.value.trim();
const bookAuthor = bookAuthorInput.value.trim();
const bookNumberOfPages = bookNumberOfPagesInput.value.trim();
const isBookRead = isBookReadCheckBox.checked;
if ( bookTitle == "" || bookAuthor == "" || bookNumberOfPages == "" ) {
alert("Please fill all fields with correct input!");
return false;
} else if (
!isValidInteger(Number(bookNumberOfPages)) ||
// if input hexadecimal (true) it will ask user to type correct number of pages format
isHexadecimal(bookNumberOfPages) ||
Number(bookNumberOfPages) <= 0
) {
alert("Please fill all fields!");
alert("Invalid number of pages format!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
} else {
const bookNumberOfPagesInt = parseInt(bookNumberOfPagesInput.value.trim(), 10);
let book = new Book(bookTitle, bookAuthor, bookNumberOfPagesInt, isBookRead);
myLibrary.push(book);
render();
}
}
Expand All @@ -52,51 +68,42 @@ function Book(title, author, pages, check) {

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
let tableBody = table.querySelector("tbody");
tableBody.innerHTML = '';
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let row = tableBody.insertRow();
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let changeReadStatusButton = document.createElement("button");
changeReadStatusButton.className = "btn btn-success";
wasReadCell.appendChild(changeReadStatusButton);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
readStatus = !myLibrary[i].check ? "No" : "Yes";
changeReadStatusButton.innerText = readStatus;

changeBut.addEventListener("click", function () {
changeReadStatusButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
let deleteBookButton = document.createElement("button");
deleteCell.appendChild(deleteBookButton);
deleteBookButton.className = "btn btn-warning";
deleteBookButton.innerHTML = "Delete";
deleteBookButton.addEventListener("click", function () {
myLibrary.splice(i, 1);
alert(`You've deleted title: ${myLibrary[i].title}`);
render();
});
}
Expand Down