This repository was archived by the owner on Aug 11, 2025. It is now read-only.
Fix FeedForwardNetwork and output bug #282
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finebouche
commented
May 20, 2024
Finebouche
commented
- Fix FeedForwardNetwork wrong creation, where some useless node were use to create the network and some usufull ones were disregarded
- and remove the possibility for the ouput to be an input to a new node
Finebouche
commented
May 20, 2024
| out_node = choice(possible_outputs) | ||
|
|
||
| possible_inputs = possible_outputs + config.input_keys | ||
| possible_inputs = list((set(self.nodes)- set(config.output_keys)) | set(config.input_keys) ) |
There was a problem hiding this comment.
This fixes new node from taking output nodes as inputs
Finebouche
commented
May 20, 2024
There was a problem hiding this comment.
This removed useless nodes from the FeedForwardNetwork
Finebouche
commented
May 20, 2024
| if n in required and all(a in s for (a, b) in connections if b == n): | ||
| t.add(n) | ||
| # select connections (a, b) where b == n | ||
| connections_to_n = [(a, b) for (a, b) in connections if b == n and a in required] |
There was a problem hiding this comment.
the change here is that a as to be in required nodes to be considered
Finebouche
commented
May 20, 2024
| """ | ||
| assert not set(inputs).intersection(outputs) | ||
|
|
||
| # Create a graph representation of the connections |
There was a problem hiding this comment.
The previous function wasn't working as intended
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.