[SSF-169] backend logic to return required actions for FM#140
Open
[SSF-169] backend logic to return required actions for FM#140
Conversation
Yurika-Kan
requested changes
Mar 29, 2026
Collaborator
Yurika-Kan
left a comment
There was a problem hiding this comment.
coolington~
one design note included about keeping previous implementation logic (donations of all statuses) & then adding the matched logic
- jest tests
- postman tested
| foodManufacturerId, | ||
| }) | ||
| .andWhere(`donation.status = :status`, { | ||
| status: DonationStatus.MATCHED, |
Collaborator
There was a problem hiding this comment.
we need to return a FM's donations -all statuses- for this page and also get complete required actions for only matched donations, so i'd suggest filtering for matched & returning the hefty payload
Collaborator
There was a problem hiding this comment.
design choice of:
- 2 endpoints (all status donations + all matched donations) - separation of concerns & conditionally controlling lighter vs heavier payload BUT frontend has to manage 2 endpoints
- 1 endpoint + conditional rendering for matched donations: one main endpoint BUT more service logic & heavier payload
leaning towards the 1 endpoint since this page with donations statuses will be frequently changing. lmk your thoughts!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-169
📝 Description
getFMDonationsin `manufacturers.service.tsDonationDetailsDtofor return type✔️ Verification
verified tests pass and tested call in postman