[SSF 170] - New Endpoints for FM Required Actions#139
Open
dburkhart07 wants to merge 6 commits intomainfrom
Open
[SSF 170] - New Endpoints for FM Required Actions#139dburkhart07 wants to merge 6 commits intomainfrom
dburkhart07 wants to merge 6 commits intomainfrom
Conversation
dburkhart07
changed the title
amywng
requested changes
Mar 30, 2026
| relations: { allocations: { order: true } }, | ||
| }); | ||
|
|
||
| const allItemsFulfilled = items.every( |
Member
There was a problem hiding this comment.
can we abstract this logic to utils and create a method like donationReadyToFulfill
Author
There was a problem hiding this comment.
we can only include logic without repo usage, since it needs to be put into the utils folder. I created a boolean function that takes in the donation items, which should reduce complexity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #170
📝 Description
✔️ Verification