feat: donation controller DTOs, donations swagger#14
Merged
Conversation
Collaborator
|
This is great! Nothing to change on your end I just had to make everything consistent. thanks for writing tests (c4c as a whole usually avoids testing code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #10.
Description
This pull request implements a foundation for the donation system by adding DTOs and mapping utilities for handling donation-relating API requests, and adds the appropriate Swagger decorations for our documentation.
CreateDonationDto,DonationResponseDto,PublicDonationDto)mappers.spec.tswith coverage for default values, privacy filtering, DTO validation, and array mapping operations.Verification
Ensure all newly created tests pass and do not break the existing test suite: