Merged
Conversation
note that information on when each drop happened isn't easy to get, I chose to simply use the first release of SLD: 2019-12-02 now that we have added the uuid for every card to the xml we could also decide to sort the set list by when that specific version was released by requesting the "released_at" field from scryfall's api, this is more effort than it is worth imo and I think it's nice to simply have a consistent sorting for sets across entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Cockatrice can display and select multiple printings of tokens, it makes more sense to include some alternate art and promo tokens. This PR adds the token printings from the various Secret Lairs that have come out, helpfully collected by Scryfall into one set (SLD). Cockatrice already has all the Secret Lair printings of cards, so it seems reasonable to have the tokens to match.