Skip to content

Conversation

@liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Oct 30, 2025

Problem

As noted in #1953, after removing a cluster node, the directories /etc/systemd/system/sbd.service.d and /run/systemd/system/sbd.service.d are left behind.

Changes

  • Ensure both directories are removed when a cluster node is removed.
  • Refactor the cleanup logic into a new function, sbd.cleanup_sbd_configurations, which is now invoked during both cluster remove <node> and sbd purge subcommands

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.75%. Comparing base (9d10628) to head (080b36e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 55.18% <23.07%> (-0.01%) ⬇️
unit 52.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 87.85% <100.00%> (-0.01%) ⬇️
crmsh/sbd.py 83.98% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 changed the title Dev: sbd: Remove sbd configuration files while removing cluster node Dev: sbd: Remove sbd configuration directories while removing cluster node Oct 30, 2025
@liangxin1300 liangxin1300 force-pushed the 20251030_rm_sbd_configuration_files branch from 1612a08 to ef054a9 Compare October 30, 2025 14:24
@liangxin1300 liangxin1300 marked this pull request as ready for review October 30, 2025 14:32
@liangxin1300 liangxin1300 merged commit 99d958b into ClusterLabs:master Nov 14, 2025
37 checks passed
liangxin1300 added a commit that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants