Dev: sbd: Minor improvements for log clarity #1949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxin1300
force-pushed
the
20251022_improve_log_msg
branch
from
3918e31 to
0f0f5ce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liangxin1300
force-pushed
the
20251022_improve_log_msg
branch
from
0f0f5ce to
5021f83
Compare
liangxin1300
commented
Oct 30, 2025
| utils.sysconfig_set(self.SYSCONFIG_SBD, **self.update_dict) | ||
| if self.cluster_is_running: | ||
| bootstrap.sync_path(self.SYSCONFIG_SBD) | ||
| logger.info("Already synced %s to all nodes", self.SYSCONFIG_SBD) |
There was a problem hiding this comment.
Already has log inside bootstrap.sync_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.