- 
                Notifications
    
You must be signed in to change notification settings  - Fork 95
 
Fix: utils: Raise UnreachableNodeError for those ssh unreachable nodes (bsc#1250645) #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0699f55    to
    744d4af      
    Compare
  
    5b9aa52    to
    79751a9      
    Compare
  
    3e97567    to
    c538eb3      
    Compare
  
    
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
c538eb3    to
    529be35      
    Compare
  
    - Drop ping-based check and only use SSH to determine node reachability - When SSH check fails, raise NoSSHError when config.core.no_ssh is set to yes - Otherwise, raise ValueError as before
529be35    to
    7aaa85e      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It is not a good practice to import a function from one "ui_*" module to another.
 - The function name 
parse_option_for_nodesis to general, and does not reflect the complex node reachability checks. If it is a module-local function, it is OK to use a short name. But when it is exposed to other modules, it needs a more descriptive name. - It is similar for 
node_reachable_check. It would be better to name itssh_readable_check. 
Problem
When SSH is not available at the peer node, configuring sbd will fail and might lead to inconsistent
See issue #1738
Changed
Raise exception when detecting that any node's SSH port is not reachable