Fix command parameter type mapping - #347
Merged
PetteriM1 merged 2 commits intoAug 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2, which is unused on the wireFLOATto ID3andR_VALUEto ID4VALUEpacket mappingWhy
The command parameter table was shifted relative to the
AvailableCommandsPacketemitted by current Bedrock versions. The correct IDs are:INT:1FLOAT:3R_VALUE:4WILDCARD_INT:5R_VALUEis backed by the relative-float parser and is used by commands such as/tpfor rotation values. ID2is unused, andVALUEis not registered as a basic parameter type.This corrects both decoding, where parameter types were interpreted as the following enum member, and encoding, where floats were written using the unused ID
2.Closes #346.