Make HTTP body length tunable at runtime via APP_HTTP_MAX_BODY_LENGTH - #266
Merged
Merged
Conversation
ngdangdat
marked this pull request as ready for review
April 29, 2026 14:00
Contributor
Author
|
@Clivern I'm very sorry for not testing the change carefully in the last PR 🙇. For this one, I built an image myself and tested if the change works. The result is put in PoW section of the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #265. The existing
APP_HTTP_MAX_BODY_LENGTHenv var is read viaApplication.compile_env, so it only takes effect at build time — flipping it on a running release has no impact. This PR makes it actually runtime-tunable, so operators can resize the limit by restarting the container with a different env value (no rebuild).What changed
Lynx.Config.max_body_length/0reads:http_max_body_lengthfrom app env with an 8 MB fallback.LynxWeb.Plug.RuntimeParserswrapsPlug.Parsersand resolveslengthinside its owninit/1(so the value is fetched afterruntime.exsruns).Plug.Parsersdirectly; the@max_body_lengthmodule attribute is gone.config :phoenix, :plug_init_mode, :runtimeso endpoint pluginit/1callbacks run at endpoint boot rather than at module compile.config/runtime.exsreadsAPP_HTTP_MAX_BODY_LENGTHand writes it into the endpoint config.PoW
The state file is uploaded successfully. Dummy lock ID is used so Bad Request is expected.