Skip to content

Conversation

@mymeditech
Copy link


Clever Coding Standards Agreement

JIRA

No JIRA ticket provided (External contribution/Security fix)

Overview

This PR updates the project dependency xmlbuilder2 to version >=4.0 in order to mitigate a downstream security vulnerability.

Currently, saml2-js depends on xmlbuilder2@^2.4.0. This older version of xmlbuilder2 transitively pulls in [email protected], which contains a known prototype pollution vulnerability (CVE-2025-64718 / GHSA-mh29-5h37-fv8m).

By updating xmlbuilder2 to version 4.0 or higher, we ensure that a patched version of js-yaml (>=4.1.1) is used, resolving the security risk.

Vulnerability Details:

  • CVE: CVE-2025-64718
  • Severity: Moderate (CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N)
  • Impact: Attackers can modify the prototype of the result of a parsed YAML document via __proto__.

Testing

This is a dependency update. Testing should focus on ensuring no regression in XML generation functionality.

  • Unit Tests: Ran the existing test suite to verify that saml2-js functionality remains stable with the new xmlbuilder2 version.

Rollout

  • Risks: Low. While xmlbuilder2 v4.0 may have API changes compared to v2.4.0, basic usage often remains compatible.

Rollback

  • Steps: Revert this commit and re-install dependencies

@mymeditech
Copy link
Author

mymeditech commented Dec 2, 2025

Link provided for creating jira issue is invalid: http://go/soc-pr. How does one create a Jira ticket in the Clever Jira workspace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant