update #76
Merged
update #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the following: - Kotlin version to 2.2.10 - Android Gradle Plugin to version 8.13.0 - Compose BOM to version 2025.08.01 - JDK version to 24 in `gradle/libs.versions.toml` - JVM target to 24 in `sample/build.gradle.kts` and `filepickerlibrary/build.gradle.kts`
This commit introduces a `configType` parameter to the `setSuccessResult` functions in `FilePickerResultHandler.kt`. This allows passing configuration type information within the result Intent. - Added `CONFIG_TYPE` constant in `Const.kt`. - Updated single and multiple URI `setSuccessResult` functions to include `configType` in the result Intent extras.
This commit updates the `PopupItem` composable to vertically center its content within the `Row`. - Modified `Row` in `PopupItem.kt` to include `verticalAlignment = Alignment.CenterVertically`.
This commit introduces the following changes:
- Passes the specific config class name (`PickMediaConfig`, `DocumentFilePickerConfig`, `ImageCaptureConfig`, `VideoCaptureConfig`) in the `setSuccessResult` function calls within their respective activities. This allows for better identification of the originating picker type.
- In `PopUpActivity`:
- Refactors the result handling from `FilePickerResultContracts.AnyFilePicker()` to simplify the conditions for setting success or canceled results.
- Sets a specific error message "User dismissed the popup" when the dialog or bottom sheet is dismissed.
- Extracts common UI logic for dialog and bottom sheet content into a new composable function `PopupContent`.
- Replaces `Row` with `horizontalScroll` and `Column` with `verticalScroll` with `LazyRow` and `LazyColumn` respectively in the `ItemList` composable for improved performance with lists of items.
This commit introduces a private `parsePickerResult` function to consolidate the logic for parsing results from file picker activities. This function is now used by `PickMedia`, `PickDocumentFile`, and `FilePicker` contracts, reducing code duplication. Additionally, the `AnyFilePicker` contract has been updated: - It no longer stores `baseConfig` as a class property. - It determines the configuration type from the intent extras (`Const.BundleExtras.CONFIG_TYPE`) in `parseResult` to correctly delegate to the appropriate specific file picker's `parseResult` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's Changed
Describe the changes you made in this PR.
✅ Checklist