-
-
Notifications
You must be signed in to change notification settings - Fork 18
pull request master to dev #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and transition steps
…cies This commit introduces the following changes to the sample app: - Added a `FilePickerWithResultList` composable to display picked files. - Integrated the result list into the `AllFilePickers` composable to show selected images, videos, and other documents. - Refactored `AllFilePickers` to manage picked files in a list and update the UI accordingly. - Enabled Coil library for image loading. - Updated various dependencies including Android Gradle Plugin, Kotlin, Maven Publish, and Truth.
This commit updates the Proguard rules for both the library and sample app to use a simpler configuration. It also enables edge-to-edge display in all Activities within the `filepickerlibrary` by calling `enableEdgeToEdge()` in their `onCreate` methods. Additionally, the sample app's version code and name have been incremented, and some minor UI adjustments have been made to the `FilePickerWithResultList` composable. Test dependencies and Kotlin JVM target settings have been removed from the library's build script.
This commit updates the Kotlin JVM target to 21 for both the library and sample app. It also removes unused test dependencies and the `ExampleUnitTest.kt` file from the sample app. Additionally, the `@Keep` annotation has been removed from various classes and functions within the `filepickerlibrary` as it is no longer necessary with the updated Proguard rules. The GitHub Actions workflow has been updated to use JDK 21. The sample app's version code and name have been incremented, and packaging options have been added to exclude specific JNI libraries.
Adds error messages and logic to file pickers to handle cases where no file is selected. - Includes new string resources for "no data" errors in document and media pickers. - Modifies `DocumentFilePickerActivity` and `MediaFilePickerActivity` to check for `clipData` when `data` is null and set a canceled result with the appropriate error message if no file is found.
This commit updates the following: - Android Gradle Plugin to version 8.12.0 - Maven Publish plugin to version 0.34.0 - Compose BOM to version 2025.07.00 - Spotless plugin to version 7.2.1 - Gradle wrapper to version 8.14.3
Replaces manual Android version checks and deprecated `getParcelableExtra` calls with `BundleCompat.getParcelable`. This simplifies the code and ensures type safety when retrieving Parcelable objects from Intent extras across different Android versions. - Updated in `PopUpActivity`, `MediaFilePickerActivity`, `DocumentFilePickerActivity`, `ImageCaptureActivity`, and `VideoCaptureActivity`. - Removed an unused `setActivityResult` function from `FilePickerResultHandler.kt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's Changed
Describe the changes you made in this PR.
✅ Checklist