-
-
Notifications
You must be signed in to change notification settings - Fork 18
Dev #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dev #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update gradle version to 8.11.1 - update agp version to 8.10.0 - remove unnecessary testOptions configuration from sample and filepickerlibrary modules
- Update Kotlin to 2.1.0 - Update core-ktx to 1.16.0 - Update lifecycle-runtime-ktx to 2.9.0
- Update build.gradle.kts files to use version catalog for dependencies and plugin management. - Add Compose dependencies and configurations. - Centralize build configuration properties like SDK versions and JDK version in `libs.versions.toml`. - Remove redundant plugin IDs from `filepickerlibrary/build.gradle.kts`. - Update Kotlin plugin alias from `jetbrains-kotlin-android` to `kotlin-android`. - Add `kotlin-compose` and `kotlin-parcelize` plugin aliases.
The `Const` object now has KDocs explaining its purpose and the purpose of its nested objects and properties. This improves code readability and maintainability.
This commit refactors the `PopUpActivity` to use Jetpack Compose for its UI. - Replaced XML layout (`ActivityPopUpBinding`) with Composable functions. - `AlertDialog` is used for dialog-style pop-ups. - `ModalBottomSheet` is used for bottom sheet-style pop-ups. - Item selection logic is handled within Composable functions. - Removed dependency on `RecyclerView` and `PopUpAdapter`. - The activity now extends `ComponentActivity` instead of `AppCompatActivity`.
This commit refactors `DocumentFilePickerActivity` to use Jetpack Compose for its UI and lifecycle management. Key changes: - Replaced `AppCompatActivity` with `ComponentActivity`. - Utilized `setContent` to define the UI with Composable functions. - Employed `rememberLauncherForActivityResult` for handling permission requests and file picking. - Managed dialog states (ask permission, go to settings) using `mutableStateOf`. - Used `AlertDialog` Composable for displaying permission-related dialogs. - Leveraged `LaunchedEffect` for initial permission checks. - Removed deprecated `showMyDialog` extension and related utility functions. - Simplified permission handling logic within the Composable structure.
… Compose - Convert `ImageCaptureActivity` and `VideoCaptureActivity` from `AppCompatActivity` to `ComponentActivity`. - Utilize `setContent` and Jetpack Compose for UI rendering and state management. - Replace `registerForActivityResult` with `rememberLauncherForActivityResult` for handling activity results and permission requests. - Implement permission handling and dialogs using Compose's state management and `AlertDialog`. - Remove legacy permission handling logic and dialog utility functions.
- Converted MediaFilePickerActivity from AppCompatActivity to ComponentActivity. - Implemented UI and logic using Jetpack Compose, including permission handling and file selection. - Replaced custom dialogs with Compose AlertDialogs. - Utilized `rememberLauncherForActivityResult` for handling activity results and permission requests. - Simplified permission checking flow. - Removed deprecated `supportActionBar?.hide()` and `title`.
…ration handling and remove deprecated code
- Created a new theme `Theme.FilePicker.Dialog` in `themes.xml` with a floating, transparent, and no-title window style. - Applied this dialog theme to `PopUpActivity`, `MediaFilePickerActivity`, `DocumentFilePickerActivity`, `ImageCaptureActivity`, and `VideoCaptureActivity` in the `AndroidManifest.xml`.
- Merge `android.yml` and `checkDetektFormatting.yml` into `ci.yml`. - The new `ci.yml` handles build, test, and publishing based on tags. - It includes caching for Gradle and JDK setup. - Test results and build artifacts are uploaded. - Releases are automatically created on GitHub for version tags. - Add issue templates for bug reports and feature requests (`bug_report.yml`, `feature_request.yml`). - Add `config.yml` to disable blank issues and link to discussions. - Add `CODEOWNERS` file. - Add `CONTRIBUTING.md` with guidelines for contributing. - Add `FUNDING.yml` to specify GitHub Sponsors. - Add `PULL_REQUEST_TEMPLATE.md` for pull requests.
…assword for publishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.