Repository navigation
Conversation
Signed-off-by: Dante <duanjl.china@gmail.com>
There was a problem hiding this comment.
No confirmed findings in the 26-line documentation change at 274aad406d4c0a3a6babcf7b4b2eec194ab122e0. The delegation approval, headless denial, notification, and completion-return guidance matches the inspected implementation and existing security contract. This supports approval; future unattended preauthorization remains a separate product decision.
Captured head checks succeeded for basic-checks, render-test, general-test, repository-checks, changes, and release classification; other checks were skipped. Legacy status has no contexts, and frozen merge CI is unavailable because the base parent differs. Review was static: no local tests or runtime reproduction; CI logs were unavailable.
Cherry Review · Passed
no findings
QA note — no functional change, skipping local testingThis PR contains no product/runtime change — every changed file is documentation, CI/automation, repository config, or test-only:
Per QA policy, PRs like this are not tested locally: there is no user-facing behaviour to exercise, and the CI gate covers what is touched here. This is not a judgement on the change itself. If a functional change is actually mixed in (or you want the diff re-checked), say so here and I will re-classify it and run the targeted regression cases. Reported by QA (cherry-ai-bot). Evidence: file list from the GitHub API; no local run performed by design. |
What this PR does
Before this PR:
The Tool Approval reference describes persistent MCP decisions without distinguishing the built-in Agent delegation tools. Scheduled coordinators can mistake Full Access or MCP auto-approval for authorization to send to another Session.
After this PR:
The reference explains that
session_sendandsession_createretain live per-call approval, including same-Agent destinations and scheduled turns withreuse_session. It describes a manual notification/interactive handoff and links the existing deliberate security ceiling and runtime completion return path.Refs #21359 (documentation alternative only; unattended preauthorization remains an open feature request).
Why we need it and why it was done in this way
The following tradeoffs were made:
Keep the existing security contract and cross-link its detailed design instead of introducing a one-off delegation bypass. Notification recipients must already be configured; the described handoff does not automate Session routing.
The following alternatives were considered:
Changing the tool to auto-approved would contradict the current live-approval ceiling and its ancestry, cycle, and budget requirements. Repeating the full runtime design here would create a second source of truth.
Links to places where the discussion took place: #21359, #21305, #18898; merged #18865 established the current policy.
Breaking changes
None. Documentation only; no permission behavior changes.
Special notes for your reviewer
pnpm check --planselected format and docs only, with no test project.pnpm checkcould not run its selected tasks: sandbox denied installation of pinned pnpm 12.6.0 into the user's package-manager directory (EPERM). Existing Node 24.12.0/dependencies were used to run the repository's four docs scripts directly: links, structure, frontmatter, and generated index all passed.git diff --checkpassed. Oxfmt excludes Markdown by repository configuration (zero matched files).Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
main/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note