feat(files): support Ctrl+A select-all in the file list - #19682
Open
ousugo wants to merge 1 commit into
Open
Conversation
Add a Ctrl+A (Cmd+A on macOS) branch to the Files page keyboard shortcut handler, reusing the existing select-all logic behind the header checkbox so both entry points share one owner. The shortcut selects every file in the current filtered list view, stays inert in the image grid (no selection model there) and while focus is inside inputs or other interactive controls, preserving native text select-all. Cover the behavior with regression tests for Cmd+A on macOS, Ctrl+A outside macOS, the interactive-control guard, and the image-grid no-op path. Signed-off-by: ousugo <dkzyxh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
After this PR:
Ctrl+A(Cmd+Aon macOS) in the Files page list view selects every file in the current filtered view, with the same effect as checking the header select-all checkbox.Related to #9616 (file-management batch operations, closed as completed when the batch-selection UI shipped — this PR completes it with a keyboard select-all entry point).
Why we need it and why it was done in this way
The following tradeoffs were made:
handleSelectAllVisible) instead of adding a new selection path, so the checkbox and the keyboard shortcut share one owner for select-all semantics.The following alternatives were considered:
Links to places where the discussion took place: N/A
Breaking changes
None.
Special notes for your reviewer
userEvent.keyboardand role-based queries perdocs/references/testing/frontend-testing.md.!isImageGridclause makes it fail (file.batch_trashgets called), so the guard clause is genuinely pinned.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
main/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note