fix(tokens): count literal special-token text safely - #19520
Merged
DeJeune merged 1 commit intoAug 27, 2026
Conversation
Signed-off-by: userInner <1239989762@qq.com>
5 tasks
DeJeune
approved these changes
Aug 27, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The exact o200k token-budget estimator used gpt-tokenizer's default special-token policy. Persisted or user-authored text containing a literal such as
<|im_start|>therefore threw before the provider request was created, and the persisted error text could trigger the same failure on the next send.After this PR:
The estimator counts special-token spellings as ordinary BPE text. It does not mutate message content or treat those spellings as encoder control tokens. Regression coverage exercises all five literals reported in the issue, both alone and inside surrounding prose.
Refs #19465
Why we need it and why it was done in this way
This tokenizer boundary estimates budgets over arbitrary user and persisted content; it is not the provider encoder. gpt-tokenizer exposes
disallowedSpecial, so an empty set expresses the required semantics directly at the narrow adapter boundary and keeps every downstream budget consumer safe.The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place: #19465 (comment)
Breaking changes
None.
Special notes for your reviewer
Validation completed locally:
<|im_start|>,<|im_end|>, and<|endoftext|>.pnpm exec vitest run --project main src/main/ai/tokens/__tests__(55 tests)pnpm typecheck:nodegit diff --checkpnpm buildChecklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
main/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note