[SVCS-541] Allow WB to log download_file/zip#285
[SVCS-541] Allow WB to log download_file/zip#285AddisonSchiller wants to merge 2 commits intoCenterForOpenScience:developfrom
Conversation
TomBaxter
left a comment
There was a problem hiding this comment.
I approve removing both the belt and the suspenders.
|
@cslzchen This is ready for next round of review. |
|
@TomBaxter thanks bunches! |
cslzchen
left a comment
There was a problem hiding this comment.
Looks good!
This PR is closely related to and blocked by #277. Please double check after the blocker is merged. Below is the comments I have for the blocker:
- Add/update tests (if necessary)
- Add a
# TODOin the code and/or a note in the PR/Ticket indicating what/Where needs to be updated for this to take effect. - Check with DjangoLE team to see if this is what they want and they know what to do with OSF side.
@felliott A question for you, is it better to combine the two PRs into one given that we probably need to recreate PRs for them.
|
@cslzchen, no, as similar as these two are they should remain separate for now. They serve different goals. This one is for counting downloads, and the needed OSF-side work is being done by B&I. The other is for changing how we track metadata, and the needed OSF-side work is being done by DLE. We will need to resolve the conflicts once they're in, but I don't know which is going to land first. |
|
@felliott Agreed. I think either can go first since there is no blocking relationship but only merge conflicts due to the same part of code being modified. |
|
This looks good as-is. The Platforms team is ready for this to go in, so merging. No need to fix the conflicts in #307 right now, we'll worry about when we get closer. Merging! |
Ticket
https://openscience.atlassian.net/browse/SVCS-541
Purpose
Remove lines stopping callbacks for
download_file/zip.This PR currently has a blocker.
https://openscience.atlassian.net/browse/OSF-8785 Needs to go through before this can go through.
Changes
Removed lines stopping logs from going through
Side effects
This is currently blocked by : https://openscience.atlassian.net/browse/OSF-8785
There is a lot of log spam/spam in general that will happen if OSF-8785 does not go through before this one.
QA Notes
Deployment Notes