[SVCS-475] Support to log metadata GET requests#277
[SVCS-475] Support to log metadata GET requests#277AddisonSchiller wants to merge 2 commits intoCenterForOpenScience:developfrom
Conversation
Removed superfluous return in remote_logging Metadata requests are currently not logged as they need an OSF addition to work correctly.
AddisonSchiller
changed the title
|
There should be tests for this, I know it there probably none to modify, but whipping up a test to ensure things are logged on_finish is critical. It's kind of a "Who watches the watchman?", situation with logs because use them to debug if there wrong we probably will find out in prod without unittests. |
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
@Johnetordoff Can you take this ticket since you already commented on it? Thanks!
- Add/update tests (if necessary)
- Add a
# TODOin the code and/or a note in the PR/Ticket indicating what/Where needs to be updated for this to take effect. - Check with DjangoLE team to see if this is what they want and they know what to do with OSF side.
Finally, you can create a new PR referencing this one if you made any further changes. Please use rebase so we can keep the ownership of the original commits. Here is what I usually do:
hub checkout https://github.com/CenterForOpenScience/waterbutler/pull/277/
git checkout -b feature/metadata-logging
git fetch upstream develop
git rebase upstream/develop
|
@Johnetordoff ignore my comments, just talked with @felliott and we will leave ticket assignment open for now. |
|
PR closed. Work continues in #307. |
4 participants
refs: https://openscience.atlassian.net/browse/SVCS-475
Purpose
Initial support for logging GET requests
Summary of changes
Removed line stopping metadata GET requests from being logged.
Added set up for logging metadata
Added
metadatato the callback ignore list. This can be removed once OSF has the correct support for the new logging featureremoved a superfluous return
Test/QA notes.
https://github.com/CenterForOpenScience/osf.io/blob/0f184000e7517f030a8b920818461279364109bd/addons/base/views.py#L299-L307
Here is where I'm pretty sure the OSF is defining what logs it wants. Since
metadatadoes not exist here, if it isn't ignored it throws a lot of annoying error logs/messages in the waterbutler container.