Change uniroot to uniroot.integer for target_param == "n"#1
Open
ddueber wants to merge 1 commit into
Open
Conversation
When searching for a sample size, uniroot wastes HUGE amounts of time narrowing down the fractional part of the solution instead of just stopping when it finds the integer part of the solution. uniroot.integer from the ssanv package will only try integer values. In my tests, this leads to about a 10x speedup. If you don't want to rely on ssanv, all uniroot.integer does is a simple binary search, which is easy enough to code.
Author
|
ok, I did a larger scale test and the speedup was more like a factor of 2 with 500 simulations per replication. Still, it was substantial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching for a sample size, uniroot wastes HUGE amounts of time narrowing down the fractional part of the solution instead of just stopping when it finds the integer part of the solution. uniroot.integer from the ssanv package will only try integer values. In my tests, this leads to about a 10x speedup. If you don't want to rely on ssanv, all uniroot.integer does is a simple binary search, which is easy enough to code.