Skip to content

Conversation

@ly-mariia
Copy link
Contributor

Purpose

Inserting the lining tool into the project;

Changes

Added and applied ruff, may need to make changes in the future as ruff improves;

  • To install changes, I recommend performing a pre-commit install;
  • Unfortunately, some of the ruff corrections are deleted as a warning during the commit, forcing the programmer to correct them manually (since ruff does not want to take responsibility for them);

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-5675

@Johnetordoff
Copy link
Contributor

@ly-mariia It looks like this was a reference PR that got used in the ticket, can it be closed now?

@sh-andriy
Copy link
Contributor

@ly-mariia It looks like this was a reference PR that got used in the ticket, can it be closed now?

@Johnetordoff I think this question is more towards @felliott or @opaduchak

@felliott
Copy link
Member

felliott commented Feb 7, 2025

Let's leave it open for a bit. We'll be revisiting this soon in an upcoming maintenance project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants