[Draft][No ticket] New linter rule to prevent leaky selectors#2351
Open
futa-ikeda wants to merge 2 commits intodevelopfrom
Open
[Draft][No ticket] New linter rule to prevent leaky selectors#2351futa-ikeda wants to merge 2 commits intodevelopfrom
futa-ikeda wants to merge 2 commits intodevelopfrom
Conversation
c5cc0ec to
fca576e
Compare
Contributor
brianjgeiger
left a comment
There was a problem hiding this comment.
Looking pretty cool so far. One thought is just in file naming. It looks like from the exports we'd only have one rule per js file. In that case, would it make more sense to have an ember-osf-web-stylelint directory and have this file be no-unlocalized-selectors.js?
Contributor
Author
Ahh, yea, that's a good call. I named it when I was assuming I could pack as many rules into that file as I wanted, but I think you're right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reviewers
Some helpful docs https://postcss.org/api/#atrule-nodes
To do
h3,li):global(.class),:global(#id)div h3,div > h3,div,\nh3)Purpose
Summary of Changes
ember-osf-web-stylelint.jsto house new rule.stylelintrcto use custom pluginScreenshot(s)
Side Effects
// stylelint-disablestatements to relevant css filesQA Notes