Skip to content

fix(signposting): fix linkset-json format #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futa-ikeda merged 1 commit into from
Feb 13, 2026
Merged

fix(signposting): fix linkset-json format #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/features/files/pages/file-detail/file-detail.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe('FileDetailComponent', () => {
expect(linkTags.length).toBe(2);
expect(linkTags[0].getAttribute('href')).toBe('http://localhost:4200/metadata/file-1/?format=linkset');
expect(linkTags[0].getAttribute('type')).toBe('application/linkset');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/file-1/?format=linkset%2Bjson');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/file-1/?format=linkset-json');
expect(linkTags[1].getAttribute('type')).toBe('application/linkset+json');
});
});
2 changes: 1 addition & 1 deletion src/app/features/preprints/pages/preprint-details/preprint-details.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ describe('PreprintDetailsComponent SSR Tests', () => {
expect(linkTags.length).toBe(2);
expect(linkTags[0].getAttribute('href')).toBe('http://localhost:4200/metadata/preprint-1/?format=linkset');
expect(linkTags[0].getAttribute('type')).toBe('application/linkset');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/preprint-1/?format=linkset%2Bjson');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/preprint-1/?format=linkset-json');
expect(linkTags[1].getAttribute('type')).toBe('application/linkset+json');
});

Expand Down
2 changes: 1 addition & 1 deletion src/app/features/project/overview/project-overview.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ describe('ProjectOverviewComponent SSR Tests', () => {
expect(linkTags.length).toBe(2);
expect(linkTags[0].getAttribute('href')).toBe('http://localhost:4200/metadata/project-123/?format=linkset');
expect(linkTags[0].getAttribute('type')).toBe('application/linkset');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/project-123/?format=linkset%2Bjson');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/project-123/?format=linkset-json');
expect(linkTags[1].getAttribute('type')).toBe('application/linkset+json');
});

Expand Down
2 changes: 1 addition & 1 deletion src/app/features/registry/pages/registry-overview/registry-overview.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ describe('RegistryOverviewComponent', () => {
expect(linkTags.length).toBe(2);
expect(linkTags[0].getAttribute('href')).toBe('http://localhost:4200/metadata/registry-1/?format=linkset');
expect(linkTags[0].getAttribute('type')).toBe('application/linkset');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/registry-1/?format=linkset%2Bjson');
expect(linkTags[1].getAttribute('href')).toBe('http://localhost:4200/metadata/registry-1/?format=linkset-json');
expect(linkTags[1].getAttribute('type')).toBe('application/linkset+json');
});

Expand Down
4 changes: 2 additions & 2 deletions src/app/shared/services/signposting.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('Service: Signposting', () => {
service.addSignposting('abcde');
const linkHeader = (mockResponseInit.headers as Headers).get('Link');
expect(linkHeader).toBe(
'<https://staging3.osf.io/metadata/abcde/?format=linkset>; rel="linkset"; type="application/linkset", <https://staging3.osf.io/metadata/abcde/?format=linkset%2Bjson>; rel="linkset"; type="application/linkset+json"'
'<https://staging3.osf.io/metadata/abcde/?format=linkset>; rel="linkset"; type="application/linkset", <https://staging3.osf.io/metadata/abcde/?format=linkset-json>; rel="linkset"; type="application/linkset+json"'
);
});

Expand All @@ -59,7 +59,7 @@ describe('Service: Signposting', () => {
},
{
rel: 'linkset',
href: 'https://staging3.osf.io/metadata/abcde/?format=linkset%2Bjson',
href: 'https://staging3.osf.io/metadata/abcde/?format=linkset-json',
type: 'application/linkset+json',
},
]);
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/services/signposting.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class SignpostingService {
},
{
rel: 'linkset',
href: this.buildUrl(baseUrl, 'linkset+json'),
href: this.buildUrl(baseUrl, 'linkset-json'),
type: LINKSET_JSON_TYPE,
},
];
Expand Down