fix bug where path was crashing http request #1692
Open
+97
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update url_encode_path Revert "update url_encode_path" This reverts commit b3bf9ad. Revert "fix bug where path was crashing http request" This reverts commit 3d8abe6. retry at url encode url encode Fix url encoding try again Update http_request.cpp Update http_request.cpp Update http_request.cpp Update http_request.cpp try again Update http_request.cpp Update http_request.cpp don't double encode make required functions public Delete fix-http-path-url-encoding.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough but successful attempt at fixing url path encoding errors with thumbnail retrieval. Thumbnail retrieval was broken on windows for files with some special characters.