feat(onboarding): import organization from store listing#2504
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edb5c9dbb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Warning Review limit reached
More reviews will be available in 40 minutes and 51 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds a "store" onboarding mode to organization setup, allowing users to import metadata from an App Store or Google Play URL. A new private backend endpoint scrapes developer name, URL, and icon from store pages. The frontend gains store-mode state, UI, and computed values. The app onboarding flow supports pre-filling via a ChangesStore Import Onboarding Flow
Sequence Diagram(s)sequenceDiagram
actor User
participant OrgOnboarding as organization.vue
participant PrivateAPI as /private/store_metadata
participant Scraper as fetchStoreMetadata()
participant AppOnboarding as AppOnboardingFlow.vue
User->>OrgOnboarding: selects "Store" mode, enters store URL
OrgOnboarding->>PrivateAPI: POST {url: storeUrlInput}
PrivateAPI->>Scraper: parse Apple/Google Play page
Scraper-->>PrivateAPI: {developer_name, developer_url, icon_url}
PrivateAPI-->>OrgOnboarding: StoreMetadata response
OrgOnboarding->>OrgOnboarding: populate orgNameInput, storeMetadata, importedLogoUrl
User->>OrgOnboarding: finishOnboarding()
OrgOnboarding->>AppOnboarding: navigate /app/new?existing_app=1&store_url=...
AppOnboarding->>AppOnboarding: applyStorePrefillFromQuery() sets existingApp/existingAppSetup
AppOnboarding->>PrivateAPI: importStoreMetadata() via storeUrl
PrivateAPI-->>AppOnboarding: updated app metadata
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/onboarding/organization.vue`:
- Around line 406-441: The fetchStoreMetadata function has a race condition
where stale responses can overwrite recent user input if the storeUrlInput
changes while a request is in flight. Capture the storeUrl value at the start of
the function before making the async request, then after receiving the response,
verify that storeUrlInput.value.trim() still matches the original captured
storeUrl before updating storeMetadata.value and orgNameInput.value on lines 431
and 435. If the URLs no longer match, skip updating the state and return early
to discard the stale response. Apply the same fix to the other location
mentioned at lines 695-703.
In `@supabase/functions/_backend/public/app/store_metadata.ts`:
- Around line 147-153: The issue is that the loop in store_metadata.ts
immediately returns an author object even when both the name and url properties
are empty strings after decoding and trimming. This stops the JSON-LD scanning
prematurely, skipping potential valid author data in later JSON-LD blocks. Fix
this by constructing the author object and only returning it if at least one of
the name or url properties is non-empty; otherwise, continue to the next
iteration of the loop so that additional JSON-LD blocks can be scanned for valid
author information.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d10ee883-22fe-4124-81c6-df05777160ef
📒 Files selected for processing (6)
messages/en.jsonsrc/components/dashboard/AppOnboardingFlow.vuesrc/pages/onboarding/organization.vuesupabase/functions/_backend/private/store_metadata.tssupabase/functions/_backend/public/app/store_metadata.tssupabase/functions/private/index.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Cap-go/capacitor-updater(manual)
riderx
force-pushed
the
codex/onboarding-store-import-shortcut
branch
from
edb5c9d to
e1bdb93
Compare
riderx
force-pushed
the
codex/onboarding-store-import-shortcut
branch
from
e1bdb93 to
7bd8d05
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bd8d05a85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/dashboard/AppOnboardingFlow.vue (1)
967-973: 🧹 Nitpick | 🔵 TrivialSwitch CLI command to use
--apikeyflag instead of positional API key argument.The command currently passes the API key as a positional argument (
npx@capgo/cli@latest i [APIKEY]), but the capgo/cli documentation explicitly recommends using the--apikeyflag to override the default key. Update line 94 to construct the command asnpx@capgo/cli@latest i --apikey ${apiKey.value ?? '[APIKEY]'}${localCommand}and update both template snippets (lines 967-973 and 1288-1294) accordingly.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/dashboard/AppOnboardingFlow.vue` around lines 967 - 973, The CLI command is currently passing the API key as a positional argument, but it should use the --apikey flag instead. Update the command construction logic (around line 94) to build the command as npx `@capgo/cli`@latest i --apikey ${apiKey.value ?? '[APIKEY]'}${localCommand} instead of the positional format. Then update both template snippets that display this command (the one shown in the diff with the cliCommandArgs loop around lines 967-973, and another similar template snippet around lines 1288-1294) to reflect the new --apikey flag format, removing the positional argument display and ensuring the flag is properly shown in the command visualization.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/dashboard/AppOnboardingFlow.vue`:
- Around line 959-963: Replace the custom Tailwind styling on the button element
with the class v-if="isCliCommandVisible" with DaisyUI button primitives (using
d- prefixed classes like d-btn) instead of the manual class attributes
containing bg-slate-950, ring-1, ring-white/10, and other custom styling. This
change should be applied to all similar copy-command buttons in the
AppOnboardingFlow.vue component to maintain consistency with the project's
button primitive conventions and ensure consistent behavior and spacing across
interactive elements.
- Around line 514-520: In the AppOnboardingFlow.vue file where the icon is being
fetched from a remote HTTPS URL, add validation after the fetch call to ensure
the response is successful and contains image data. Before calling
response.blob(), check that response.ok is true to ensure the HTTP request
succeeded, and verify that the response's content-type header indicates an image
format (check for headers like 'image/png', 'image/jpeg', etc.). Only proceed
with creating the File object if both validations pass; otherwise, handle the
invalid response appropriately by returning null or throwing an error with a
descriptive message.
- Around line 372-388: The applyImportedStoreMetadata function only
conditionally sets values but does not clear previously imported data, allowing
stale metadata from prior imports to persist. At the start of the
applyImportedStoreMetadata function, reset the store-derived fields
(importedStoreAppId, storeIconPreview, and storeScreenshotPreview) to empty or
null values before applying the new imported data. This ensures that if a
subsequent import returns partial metadata, old values from previous imports do
not bleed through.
In `@supabase/functions/_backend/public/app/store_metadata.ts`:
- Around line 177-206: The functions extractGooglePlayDeveloperName and
extractDeveloperUrl each independently call extractJsonLdAuthor, causing the
same JSON-LD parsing to occur twice when both functions are used together.
Refactor extractGooglePlayDeveloperName and extractDeveloperUrl to accept the
author object as a parameter instead of calling extractJsonLdAuthor internally.
Then, in the calling code where both functions are invoked (in
fetchStoreMetadata for Google Play pages), call extractJsonLdAuthor once and
pass the returned author object to both functions.
---
Outside diff comments:
In `@src/components/dashboard/AppOnboardingFlow.vue`:
- Around line 967-973: The CLI command is currently passing the API key as a
positional argument, but it should use the --apikey flag instead. Update the
command construction logic (around line 94) to build the command as npx
`@capgo/cli`@latest i --apikey ${apiKey.value ?? '[APIKEY]'}${localCommand}
instead of the positional format. Then update both template snippets that
display this command (the one shown in the diff with the cliCommandArgs loop
around lines 967-973, and another similar template snippet around lines
1288-1294) to reflect the new --apikey flag format, removing the positional
argument display and ensuring the flag is properly shown in the command
visualization.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 384f9952-4bf0-4731-86ea-115f86641482
📒 Files selected for processing (6)
messages/en.jsonsrc/components/dashboard/AppOnboardingFlow.vuesrc/pages/onboarding/organization.vuesupabase/functions/_backend/private/store_metadata.tssupabase/functions/_backend/public/app/store_metadata.tssupabase/functions/private/index.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Cap-go/capacitor-updater(manual)
riderx
force-pushed
the
codex/onboarding-store-import-shortcut
branch
from
7bd8d05 to
7e53dc8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e53dc8455
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
riderx
force-pushed
the
codex/onboarding-store-import-shortcut
branch
from
7e53dc8 to
2cfd0fe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cfd0fe95a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
riderx
force-pushed
the
codex/onboarding-store-import-shortcut
branch
from
2cfd0fe to
8c377b2
Compare
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a7a996fc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const importedLogoUrl = computed(() => { | ||
| const storeIcon = storeMetadata.value?.icon_data_url || storeMetadata.value?.icon_url || '' | ||
| return websitePreview.value?.icon || storeIcon |
There was a problem hiding this comment.
If a website preview request finishes after the user switches to the name or store flow, fetchWebsitePreview() can still populate websitePreview; this computed value then remains truthy and is preferred over the store icon. Because the new create path auto-uses any importedLogoUrl, that stale website logo can be uploaded and the logo step skipped for a non-website organization. Only return the website icon when mode === 'website' and the store icon when mode === 'store'.
Useful? React with 👍 / 👎.
1 participant
Summary (AI-generated)
Adds a faster organization onboarding path for users who already have a published app:
Motivation (AI-generated)
A common onboarding case is that the organization name and first app name come from the same published app listing. Asking users to enter both manually slows down setup. Importing the developer name and app details from the store listing reduces duplicate typing while still allowing users to edit the generated values.
Business Impact (AI-generated)
This should reduce friction in the first-run setup flow, especially for teams migrating an existing production app to Capgo. A shorter path from store link to org + app setup can improve activation and make the onboarding flow feel more tailored to existing app publishers.
Demo (AI-generated)
Test Plan (AI-generated)
bun lintsrc/services/compatibilityEvents.tsJSDoc warning.bun typecheckSummary by CodeRabbit