docs: document getSecureCredentials error code 21 - #112
Conversation
Document NO_PROTECTED_CREDENTIALS_FOUND (21) in README and BiometricAuthError enum. Covers platform-specific rejection messages for missing protected credentials on getSecureCredentials. Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe plugin now documents biometric error code 21 for missing protected credentials or data. The public error enum includes ChangesSecure retrieval error contract
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This localized documentation and enum update does not introduce an actionable merge-blocking risk; it is merge-ready after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Beta npm buildMaintainers can publish this PR to npm for fast testing. Comment The workflow will:
Security note: beta publish is only enabled for branches inside this repository. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Note that isCredentialsSaved/isDataSaved cover unprotected storage too - Document getSecureData() alongside getSecureCredentials() for error 21 Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
What
21(NO_PROTECTED_CREDENTIALS_FOUND) forgetSecureCredentials()when no biometric-protected credentials exist for the requested serverBiometricAuthError.NO_PROTECTED_CREDENTIALS_FOUNDto the TypeScript enum so consumers can reference the code in app logicgetSecureCredentials()API docs with platform-specific rejection messagesFixes #108
Why
getSecureCredentials()can receive rejection code21when credentials were never stored with biometric protection, were deleted, or were invalidated (for example after biometric enrollment changes)How
21to the manual README error table with Android/iOS message differences:No protected credentials foundNo protected credentials found for serverNO_PROTECTED_CREDENTIALS_FOUND = 21toBiometricAuthErrorinsrc/definitions.tsgetSecureCredentials()JSDoc and regenerated API docs viabun run docgenTesting
bun run buildbun run lintNot Tested
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
New Features
Documentation