fix(android): support face unlock and device credentials (fixes #45) - #100
Conversation
…tricPrompt Expand Android verifyIdentity() beyond BIOMETRIC_STRONG-only so face unlock and other weak-class biometrics work by default, honor allowedBiometryTypes filters, and support DEVICE_CREDENTIAL when explicitly requested. Fixes #45 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
Beta npm buildMaintainers can publish this PR to npm for fast testing. Comment The workflow will:
Security note: beta publish is only enabled for branches inside this repository. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
BiometricPromptto strong and weak biometric classes so face unlock works on devices that classify it as weak biometrics (fixes Only supports fingerprint authentication on Android #45).allowedBiometryTypesto the correct prompt/Keystore authenticators (fingerprint-only stays strong-class; face/iris/multiple allow weak+strong;DEVICE_CREDENTIALenables PIN/pattern/password without a cancel button).isAvailable()to match the updatedverifyIdentity()behavior.Test plan
bun run verify(iOS, Android unit tests, web build)verifyIdentity()shows face promptallowedBiometryTypes: [FINGERPRINT]shows fingerprint-only promptallowedBiometryTypes: [DEVICE_CREDENTIAL]shows PIN/pattern/password promptMade with Cursor