Import upstream sampling correctness fix - #1
Merged
CamzCodex merged 1 commit intoJul 21, 2026
Conversation
- Remove early return in top_k_top_p_filtering that caused top-p to be ignored when top-k was enabled - Fix None guard in sample_from_logits to avoid TypeError when only one of top_k/top_p is provided - Normalize None args to defaults before calling filter function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports shiyu-coder#262 into the hardening branch. This preserves the original contributor commit and fixes combined top-k/top-p filtering plus optional sampling arguments.