tipi.build generated CMakelists#1
Open
daminetreg wants to merge 4 commits intoCallForSanity:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @CallForSanity,
As I went on your profile and saw the CMake support for the fun libcity library, I thought why not try it with tipi. I've let tipi build the tests as well, as the existing cmake did not include the test folder.
Here I propose a change to use libcity with tipi easily, it also enable depending on libcity in another project by simply adding the following to
.tipi/deps:{ "CallForSanity/libcity": { } }I also added auto-generated CI support with the command
tipi cion github actions and fixed some const correctness topics pointed out by libc++.The generated CMakeLists are put in
build/<target>/recipe/CMakeLists.txtat build time and hence it would also be possible to delete the hand written cmake.Do you think I should try Pull-Requesting it to the upstream ? 😄