Feature/merge from 9.next to 10.next #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/openid connect linkedin
implements CachedRbac functionality.
Add the ability to use a callback in bypassAuth in permissions
Implement LinkedIn via OpenID-Connect
There was a problem hiding this comment.
Pull Request Overview
This PR merges changes from branch 9.next to 10.next and updates the social authentication documentation.
- Updated the LinkedIn entry to indicate deprecation due to the switch to OpenID Connect.
- Added a new documentation entry for the LinkedIn OpenID Connect provider.
Files not reviewed (13)
- composer.json: Language not supported
- config/auth.php: Language not supported
- config/permissions.php: Language not supported
- src/Rbac/CachedRbac.php: Language not supported
- src/Rbac/Permissions/AbstractProvider.php: Language not supported
- src/Rbac/Rbac.php: Language not supported
- src/Rbac/Rules/OTPRule.php: Language not supported
- src/Social/Mapper/LinkedInOpenIDConnect.php: Language not supported
- src/Social/Service/OpenIDConnectService.php: Language not supported
- tests/TestCase/Rbac/RbacTest.php: Language not supported
- tests/TestCase/Social/Mapper/LinkedInOpenIDConnectTest.php: Language not supported
- tests/TestCase/Social/Service/OpenIDConnectServiceTest.php: Language not supported
- tests/bootstrap.php: Language not supported
Comments suppressed due to low confidence (2)
Docs/Documentation/Social.md:15
- [nitpick] Consider standardizing the deprecated provider name format; for example, use a colon for clarity ('LinkedIn (Deprecated: Switched to OpenID Connect)').
+ LinkedIn (Deprecated, they switched to OpenID-Connect)
Docs/Documentation/Social.md:16
- [nitpick] The new provider name 'LinkedInOpenIDConnect' could be more readable if formatted with spaces, for example: 'LinkedIn OpenID Connect'.
+ LinkedInOpenIDConnect (New, OIDC based authentication)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.