Skip to content

BAL-204-GP-Missing CSV data#206

Merged
gperissetcelteeka merged 3 commits into
mainfrom
bug/BAL-204-GP-CSV-Bug
Jun 26, 2025
Merged

BAL-204-GP-Missing CSV data#206
gperissetcelteeka merged 3 commits into
mainfrom
bug/BAL-204-GP-CSV-Bug

Conversation

@gperissetcelteeka
Copy link
Copy Markdown
Collaborator

@gperissetcelteeka gperissetcelteeka commented Jun 24, 2025

CSV Missing Data

♻️ Current situation & Problem

This PR fixes #204 which consisted in missing some data when participants were sharing their activity using the Share Date feature.
The fix itself consists in hardening the way we dispatch events in Balance/ActivityLogging/ActivityLogStore.swift.

⚙️ Release Notes

*No breaking changes for this release.

✅ Testing

All testing was manual

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 5.06%. Comparing base (bb96533) to head (fedbf52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Balance/ActivityLogging/ActivityLogStore.swift 6.67% 14 Missing ⚠️
Balance/Balance.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #206      +/-   ##
========================================
- Coverage   5.45%   5.06%   -0.39%     
========================================
  Files        130     130              
  Lines       2149    2158       +9     
========================================
- Hits         117     109       -8     
- Misses      2032    2049      +17     
Files with missing lines Coverage Δ
Balance/Balance.swift 72.73% <0.00%> (-8.22%) ⬇️
Balance/ActivityLogging/ActivityLogStore.swift 7.41% <6.67%> (-29.43%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb96533...fedbf52. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gperissetcelteeka gperissetcelteeka enabled auto-merge (squash) June 24, 2025 15:20
Copy link
Copy Markdown
Collaborator

@sebastianricaldoni sebastianricaldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
utACK

@gperissetcelteeka gperissetcelteeka merged commit 75a2db8 into main Jun 26, 2025
5 checks passed
@gperissetcelteeka gperissetcelteeka deleted the bug/BAL-204-GP-CSV-Bug branch June 26, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug report: Missing information in CSV Files

2 participants